lockless file descriptor lookup
brde at optusnet.com.au
Thu May 14 04:47:52 UTC 2009
On Tue, 12 May 2009, Jeff Roberson wrote:
> On Tue, 12 May 2009, Dag-Erling Sm?rgrav wrote:
>> Jeff Roberson <jroberson at jroberson.net> writes:
>>> I'd also appreciate it if someone could look at my volatile cast and
>>> make sure I'm actually forcing the compiler to refresh the fd_ofiles
>>> array here:
>>> + if (fp == ((struct file *volatile*)fdp->fd_ofiles)[fd])
This has 2 style bugs (missing space after first '*' and missing space
before second '*'.
It isn't clear whether you want to refresh the fd_ofiles pointer to the
(first element of) the array, or the fd'th element. It is clear that
you don't want to refresh the whole array. The above refreshes the
fd'th element. Strangely, in my tests gcc refreshes the fd'th element
even without the cast. E.g.,
results in 1 memory access for each of the [fd]'s.
>> The problem is that since it is not declared as volatile, some other
>> piece of code may have modified it but not yet flushed it to RAM.
> That is an acceptable race due to other guarantees. If it hasn't been
> committed to memory yet, the old table still contains valid data. I only
> need to be certain that the compiler doesn't cache the original ofiles value.
> It can't anyway because atomics use inline assembly on all platforms but I'd
> like it to be explicit anyway.
It shouldn't matter that atomics use inline asm. Non-broken inline
asm declares all its inputs and outputs, so compilers can see what it
changes just as easily as for C code (and more easily than for non-
inline asm or C).
Anyway, you probably need atomics that have suitable memory barriers.
Memory barriers must affect the compiler and make it perform refreshes
for them to work, so you shouldn't need any volatile casts. E.g., all
atomic store operations (including cmpset) have release semantics even
if they aren't spelled with "_rel" or implemented using inline asm.
On amd64 and i386, they happen to be implemented using inline asm with
"memory" clobbers. The "memory" clobbers force refreshes of all
More information about the freebsd-arch