smb(4): address format

John Baldwin jhb at freebsd.org
Wed Jan 21 06:36:49 PST 2009


On Wednesday 21 January 2009 9:20:52 am Andriy Gapon wrote:
> on 21/01/2009 15:57 John Baldwin said the following:
> > On Friday 16 January 2009 8:17:26 am Andriy Gapon wrote:
> >> on 15/01/2009 20:08 M. Warner Losh said the following:
> >>> The format that is preferred on FreeBSD is xxxxxxxx0b.  That's the
> >>> format that the existing IIC bridge drivers use and deal with.  I've
> >>> not looked at the SMB drivers, but I went through all the iic bridge
> >>> drivers in the 6.x time frame and made sure they were all consistent.
> >>> If I missed the smb drivers, that's my bad.
> >>>
> >>> I could find no evidence that there was a format that was more
> >>> preferred apart from the dozen data sheets that I'd read at the time
> >>> which used the xxxxxxx0b.
> >> What about the attached patch.
> >> It brings ichsmb in line with this format and also adds a simple check
> >> into smb(4).
> > 
> > Commit!
> > 
> 
> I guess this would also need a note in UPDATING and some HEADS UP in
> current at .

Sure, though I had a hard time getting people to test the locking changes to 
the smbus(4) drivers, so I doubt many current@ users actually use smbus(4).

-- 
John Baldwin


More information about the freebsd-arch mailing list