RFC: New VOP to translate vnode to its component name

[Joe Marcus Clarke]

On Mon, 2008-12-08 at 11:20 +0100, Dag-Erling Smørgrav wrote:
> Joe Marcus Clarke <marcus at FreeBSD.org> writes:
> > Here is a patch to HEAD, along with a man page, for VOP_CNP.  VOP_CNP
> > translates a vnode to its component name.  It is currently called from
> > vn_fullpath1() to traverse a vnode hierarchy when cache lookups for
> > those vnodes fail.  I have currently implemented VOP_CNP for devfs and
> > pseudofs.  Kostik has thoroughly reviewed the devfs implementation.  I
> > only recently did the pseudofs implementation at his request.
> 
> I would prefer pidbuf[PFS_NAMLEN] to pidbuf[11], and you can avoid two
> strlen()s by storing the return value from snprintf().  Also, defining
> pidbuf at the start of the block instead of the start of the function is
> a style(9) violation.  Other than that, the pseudofs part of the patch
> has my approval.

Thanks for the feedback.  This was a section of the pfs code I
especially wanted some comments on.  I'll take care of your suggestions.

Joe

-- 
Joe Marcus Clarke
FreeBSD GNOME Team      ::      gnome at FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/freebsd-arch/attachments/20081208/58036e8e/attachment.pgp