Need a code review

[Oleksandr Tymoshenko]

Dag-Erling Smørgrav wrote:
> Oleksandr Tymoshenko <gonzo at freebsd.org> writes:
>> openpam detects static modules build using cpp(1) condition:
>> #if defined(__GNUC__) && !defined(__PIC__) && !defined(NO_STATIC_MODULES)
>> The problem is that gcc MIPS option -mabi-calls assumes -fpic for both
>> static and dynamic builds. So the question is: would defining
>> NO_STATIC_MODULES for MIPS be enough or it should be addressed
>> upstream?
> 
> "upstream" in this case means me.
     Here is new fix: http://people.freebsd.org/~gonzo/mips2/libpam2.diff
The idea is to set define explicitly for dynamic case rather then rely on
__PIC__.

-- 
gonzo