Code review request: small optimization to localtime.c

[Dag-Erling Smørgrav]

"M. Warner Losh" <imp at bsdimp.com> writes:
> Please find enclosed some small optimizations.  [...]

almost completely unrelated, but while you're at it:

>  	if (__isthreaded != 0) {

__isthreaded is clearly (by its name) a predicate, comparing it
explicitly to 0 is redundant and disrupts my flow of thought when
reading the code.  Instead of just reading "if is threaded", I have to
take a second to parse the expression and check which way the comparison
goes.

We already have a policy (unwritten as far as I know) of using explicit
comparisons for variables which are not clearly predicates, can we also
have one of *not* using explicit comparisons for those that are?  And
document both cases in style(9)?

DES
-- 
Dag-Erling Smørgrav - des at des.no