Fw: cvs commit: src/sys/vm swap_pager.c vm_fault.c vm_map.c vm_page.c vm_pageq.c

Peter Jeremy peterjeremy at optushome.com.au
Wed Mar 8 01:22:33 PST 2006


On Tue, 2006-Mar-07 23:37:28 -0700, M. Warner Losh wrote:
>This is the first commit of many to do what the comment says.
...
>  Log:
>  Remove leading __ from __(inline|const|signed|volatile).  They are
>  obsolete.  This should reduce diffs to NetBSD as well.

K&R function definitions are even more obsolete but still used
throughout the kernel.  IMHO, potential diff-reduction to NetBSD
seems a fairly flimsy reason for a significant amount of churn.

Also, any diff reduction with NetBSD is probably outweighed by
the diff increase with other FreeBSD branches.

Maybe this should be treated like whitespace cleanup - something to
do if you're going to be doing something non-trivial in the source
file.  (There are probably other cleanups in the same category).

-- 
Peter Jeremy


More information about the freebsd-arch mailing list