ifnet cloning changes

Sam Leffler sam at errno.com
Sat Apr 8 05:04:28 UTC 2006


Frank Mayhar wrote:
> On Fri, 2006-04-07 at 18:07 -0700, Sam Leffler wrote:
>> modifies the SIOCIFCREATE api in the kernel so that an opaque parameter 
>> block can be passed down to ifnet cloning routines (actually the user 
>> address is passed down and the caller must do the copyin since it alone 
>> knows the size of the parameter block).
> 
> Isn't that a recipe for potential breakage?  Why not make the api
> receive a vector, i.e. buffer/length?  The "caller" will know the actual
> layout of the parameter block but other kernel routines will at least be
> able to deal with it, since they'll know the size.

Feel free to provide an alternative implementation; I'm not wed to the code.

	Sam


More information about the freebsd-arch mailing list