Bug in #! processing - One More Time

[Garance A Drosihn]

At 12:33 PM +0200 2/24/05, Maxim Sobolev wrote:
>Garance A Drosihn wrote:
>>
>>As I see it, we have the following choices to fix this:
>>
>>1) MFC the January 31st change to kern/imgact_shell.c to 5.3-stable,
>>    as it is.  This means we haven't fixed the problem that people
>>    complained about in 2002 and again in 2004.  And I still think
>>    it is "not appropriate" for the execve() system to be deciding
>>    what '#' means on that line.  The biggest advantage is that this
>>    means 5.4-release will behave exactly the same as 3.5 through
>>    5.3-release have behaved.

We have the code-freeze coming up on Wednesday.  It turns out the
Jan 31st change had some bugs in it, and afaik we are still coming
up with a better version of that for *current*, never mind -stable.

At this point I think we should revert change 1.26.4.1 in -stable,
such that 5.4-release will behave the same way as all previous
releases.  Which is to say, it will continue to look for '#' on
the shebang line, and ignore everything after one is found.

I have a patch ready to do this, assuming people aren't too upset
at the idea.  I just don't feel comfortable trying to rush through
multiple changes for this issue at the last minute.

-- 
Garance Alistair Drosehn            =   gad at gilead.netel.rpi.edu
Senior Systems Programmer           or  gad at freebsd.org
Rensselaer Polytechnic Institute    or  drosih at rpi.edu