[Bug 191471] [patch] www/mod_perl2 does not build against apache24

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191471

papowell at astart.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |papowell at astart.com

--- Comment #13 from papowell at astart.com ---
With respect to your patches,  I went to the SVN respository 
http://svn.apache.org/repos/asf/perl/modperl/branches/httpd24/

downloaded this version and discovered that the patch-pre-hook already appears
to be applied:


The second patch, mp24-apache24.patch is interesting.

+.if ${APACHE_VERSION} > 22
+       ${REINPLACE_CMD} -e "s,remote_addr,client_addr,g" \
+               -e "s,remote_ip,client_ip,g" \
+               -e "s/'loglevel'/'log.level'/g" \
+               ${WRKSRC}/xs/maps/apache2_structures.map
+       ${REINPLACE_CMD} -e "s,remote_addr,client_addr,g" \
+               -e "s,remote_ip,client_ip,g" \
+               -e "s/'loglevel'/'log.level'/g" \
+               ${WRKSRC}/xs/tables/current/Apache2/StructureTable.pm
+.endif

This is changing the remote_addr to client_addr, remote_ip to client_ip,
and loglevel to log.level.  I am afraid I am not a Perl/XS wizard,
so I am having a bit of a problem deciding if this is needed or has
already been done in the CSV download.  There already seem to be some
client_addr, client_ip symbols in those files.  Where does the log.level come
in?

Question: what changes in the API (yeah I looked at
http://httpd.apache.org/docs/current/developer/new_api_2_4.html, they sure did
not spare the hot sauce on this one) required these changes?

-- 
You are receiving this mail because:
You are the assignee for the bug.