ports/181421: [patch] www/mod_rivet -- update to 2.1.2
Pietro Cerutti
gahr at FreeBSD.org
Mon Sep 2 07:40:01 UTC 2013
The following reply was made to PR ports/181421; it has been noted by GNATS.
From: Pietro Cerutti <gahr at FreeBSD.org>
To: bug-followup at FreeBSD.org
Cc: Jeff Lawson <jeff.lawson at flightaware.com>
Subject: Re: ports/181421: [patch] www/mod_rivet -- update to 2.1.2
Date: Mon, 2 Sep 2013 09:36:53 +0200
--kfjH4zxOES6UT95V
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On 2013-Aug-30, 22:18, Jeff Lawson wrote:
> The upgrade to Rivet 2.1.2 was actually already completed by PR 180444
> http://www.freebsd.org/cgi/query-pr.cgi?pr=3D180444
Oh, I must have missed it.=20
>=20
> Although the additional configuration options provided by this patch is
> functionality and flexibility beyond the scope of the above PR, I don't
> think there is sufficient demand for those non-default modes to
> necessitate complicating the port installation with them.a
I agree that the default installation is probably enough for most users,
but I also think that the two options IMP_NS and EXP_CMD are nice to
have, and the complexity added to the Makefile is really negligeable.
It's just a matter of two OPTIONS and two additional CONFIGURE_ARGS
arguments.
> Also of note, your patch enforces a USE_TCL=3D86 which is unnecessarily
> strict since it prevents users of Tcl 8.5, which is still a supported
> version. USE_TCL=3D85+ is sufficient, and is what was put in place by ab=
ove
> PR.
Yes, this was probably a left-over of a previous patch. Thanks for
pointing this out.
I'll close this PR now and submit a new one for IMP_NS and EXP_CMD.
--=20
Pietro Cerutti
The FreeBSD Project
gahr at FreeBSD.org
PGP Public Key:
http://gahr.ch/pgp
--kfjH4zxOES6UT95V
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.21 (FreeBSD)
iEYEARECAAYFAlIkQBQACgkQwMJqmJVx946FbwCgnE/9whfMSQgzoJfLr3fV2v/4
G4MAmwTqTuBZCSF75kHXKPmhCtbWv6yo
=g3GH
-----END PGP SIGNATURE-----
--kfjH4zxOES6UT95V--
More information about the freebsd-apache
mailing list