question about PR: ports/147009: Mk/bsd.apache.mk: [patch] default to www/apache22

[Philip M. Gollucci]

On 01/07/11 14:37, Olli Hauer wrote:
> However I'm a friend of more explicit test, so I like this more.
> 
> .elif ${USE_APACHE:C/\.//:C/\+//:C/13//:C/20//:C/22//:C/24//} == ""
> or
> .elif ${USE_APACHE:C/\.//:C/\+//:S/^13//:S/^20//:S/^22//:S/^24//} == ""
Seems logical.

> The following lines in bsd.apache.mk should be reviewed, for example
> APACHE_SUPPORTED_VERSION is nowhere used in ports/MK/*
This is used in some ports though I'm not sure I'm a fan of it.

> ================================================
> USE_APACHE= 1.3 / 13  => APACHE_VERSION=13, make: error version ...
this shouldn't fail, it should use 13

> USE_APACHE= 1.3+/13+  => APACHE_VERSION=22, make: OK
> 
> USE_APACHE= 2.0 / 20  => APACHE_VERSION=20, make: error version ...
ditto above, should use 20

> USE_APACHE= 2.0+/20+  => APACHE_VERSION=22, make: OK
> 
> USE_APACHE= 2.2 / 22  => APACHE_VERSION=22, make: OK
> USE_APACHE= 2.2+/ 22+ => APACHE_VERSION=22, make: OK
> 
> USE_APACHE= 2.4 / 24  => APACHE_VERSION=24, make: error version ...
> USE_APACHE= 2.4+/ 24+ => APACHE_VERSION=24, make: error version ...
both of these should use 24

bsd.perl.mk / bsd.python.mk might be helpful for the 'range' or -+ logic
though I'm not sure its compatible.





-- 
------------------------------------------------------------------------
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70  3F8C 75B8 8FFB DB9B 8C1C
Philip M. Gollucci (pgollucci at p6m7g8.com) c: 703.336.9354
VP Apache Infrastructure; Member, Apache Software Foundation
Committer,                        FreeBSD Foundation
Consultant,                       P6M7G8 Inc.
Sr. System Admin,                 Ridecharge Inc.

Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 188 bytes
Desc: OpenPGP digital signature
Url : http://lists.freebsd.org/pipermail/freebsd-apache/attachments/20110107/d9e42ab7/signature.pgp