please test qemu port update

[Jung-uk Kim]

On Thursday 28 April 2005 03:14 pm, Jung-uk Kim wrote:
> On Thursday 28 April 2005 03:02 pm, Juergen Lock wrote:
> > On Wed, Apr 27, 2005 at 07:36:18PM -0400, Jung-uk Kim wrote:
> > > On Wednesday 27 April 2005 03:04 pm, Juergen Lock wrote:
> > > > With the help of Jung-uk Kim i have made an update for the
> > > > qemu port that might :) now actually work on amd64 as well. 
> > > > Please test. (I also haven't tested 4.11 or 6.0 i386.)
> > > >
> > > > remove these files: files/patch-ab,
> > > > files/patch-target-sparc::op_helper.c
> > > >
> > > >  (btw I'm not subscribed on -amd64 so if you remove
> > > > -emulation please Cc me if you want me to see followups...)
> > >
> > > ---- >8 --- SNIP!!! --- >8 ----
> > >
> > > Juergen,
> > >
> > > sorry but it doesn't work.  You missed few things in Makefile.
> > > Since QEMU 0.7.0 is released, I think it's good time to update
> > > it, too. ;-) Update to QEMU 0.7.0 and Makefile fix is attached.
> >
> > Hmm I wonder why the Makefile worked for me...  Do you have
> > unusual things in your environment or in make.conf?
>
> No.
>
> > Or is this a difference between i386 and amd64?
>
> I believe Makefile.target is doing something wrong but I haven't
> found it yet.  I believe the culprit is Makefile.target not
> checking ARCH == amd64 but x86_64.  In fact, it works perfect for
> i386.

Yup, that's it.  MAKE_ENV was overriding ARCH==x86_64 in QEMU's 
makefiles.

> > And if it really is, I would prefer setting the right variables
> > (like USE_GMAKE, see /usr/ports/Mk/bsd.port.mk) instead of simply
> > overriding the do-* targets.
>
> I'd love to find it out.  I will let you know when I get that
> right.

The final patch (I hope) is attached.  This version includes few minor 
fixes too.

I think it is commitable now.

Thanks,

Jung-uk Kim

> Thanks,
>
> JK
>
> > 	Juergen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: qemu-port.diff
Type: text/x-diff
Size: 88952 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-amd64/attachments/20050429/996c1287/qemu-port-0001.bin