amd64/74669: The port math/octave is marked BROKEN on amd64

[Roland Smith]

The following reply was made to PR amd64/74669; it has been noted by GNATS.

From: Roland Smith <rsmith at xs4all.nl>
To: "Conrad J. Sabatier" <conrads at cox.net>
Cc: FreeBSD-gnats-submit at freebsd.org, freebsd-amd64 at freebsd.org
Subject: Re: amd64/74669: The port math/octave is marked BROKEN on amd64
Date: Sat, 4 Dec 2004 18:04:10 +0100

 --TRYliJ5NKNqkz5bu
 Content-Type: multipart/mixed; boundary="+QahgC5+KEYLbs62"
 Content-Disposition: inline
 
 
 --+QahgC5+KEYLbs62
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Sat, Dec 04, 2004 at 08:27:28AM -0600, Conrad J. Sabatier wrote:
 >
 > A better fix would be to determine exactly where -fPIC is needed and
 > apply patches where appropriate, but this is fine for a "quick fix".
 
 Ok, I've looked into it, and the problem seems to be in the libglob that
 is included in octave. When libglob.a is linked into liboctave.so, the
 linking fails because libglob isn't compiled with -fPIC. Included is a
 new patch for blob's Makefile.in, which should go in files. Also
 included is a new patch for the ports Makefile, removing the BROKEN
 state for octave.
 
 Unfortunately I can only test this myself on amd64. Could someone
 confirm that this doesn't hurt on other platforms, especially i386?
 
 Roland
 --=20
 R.F. Smith                           /"\    ASCII Ribbon Campaign
 r s m i t h @ x s 4 a l l . n l      \ /    No HTML/RTF in email
 http://www.xs4all.nl/~rsmith/         X     No Word docs in email
                                      / \    Respect for open standards
 
 --+QahgC5+KEYLbs62
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="patch-glob:makefile.in"
 Content-Transfer-Encoding: quoted-printable
 
 --- glob/Makefile.in.orig	Sat Dec  4 16:59:54 2004
 +++ glob/Makefile.in	Sat Dec  4 17:00:04 2004
 @@ -25,7 +25,7 @@
 =20
  CC =3D @CC@
  CPPFLAGS =3D @CPPFLAGS@
 -CFLAGS =3D @CFLAGS@
 +CFLAGS =3D @CFLAGS@ -fPIC
 =20
  # Information determined by configure.
  DEFS =3D @DEFS@
 
 --+QahgC5+KEYLbs62
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="octave-makefile.patch"
 Content-Transfer-Encoding: quoted-printable
 
 --- Makefile.orig	Fri Dec  3 20:36:40 2004
 +++ Makefile	Sat Dec  4 16:57:35 2004
 @@ -23,10 +23,6 @@
 =20
  .include <bsd.port.pre.mk>
 =20
 -.if ${ARCH} =3D=3D "amd64"
 -BROKEN=3D		"Does not build on amd64 (Shared libraries must be compiled wit=
 h -fPIC)"
 -.endif
 -
  .if ${PORTOBJFORMAT} =3D=3D "elf"
  GNU_HOST=3D	${ARCH}-portbld-freebsd${OSREL}
  .else
 
 --+QahgC5+KEYLbs62--
 
 --TRYliJ5NKNqkz5bu
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.6 (FreeBSD)
 
 iD8DBQFBse4KEnfvsMMhpyURAuMtAJ0akVnVxG8a/6xngzKy37Z/+wPTVACgnHhW
 MhTpQR5cIWKl6mUY+ejaSk4=
 =qk/E
 -----END PGP SIGNATURE-----
 
 --TRYliJ5NKNqkz5bu--