firefox build fails on alpha

[Anton Shterenlikht]

On Mon, Aug 18, 2008 at 05:39:40PM +0000, freebsd at sopwith.solgatos.com wrote:
> From: Dieter <freebsd at sopwith.solgatos.com>
> 
> > but I cannot see where PR_BYTES_PER_xxx are defined.
> 
> find dir -name \*.h | xargs grep PR_BYTES_PER_

well.. these are defined only in
/usr/ports/www/firefox3/work/mozilla/nsprpub/pr/src/md/mac/prcpucfg.h

that is for Mac, I think. But under unix this file doesn't appear:

% cd /usr/ports/www/firefox3/work/mozilla/nsprpub/pr/src/md/
% ls
Makefile.in     mac             prosdep.c       windows
beos            os2             unix
%
% ls ./unix/*.h
ls: No match.
%

I'm not sure what this means.

> If that doesn't find it, leave out the -name \*.h
> 
> > I think on alpha unsigned int should be 32 bit, it that correct?
> 
> Should be.  Easily verified:

yes, int is 32 bit.

Perhaps the problem is not in pldhash.h, but in nsCookieEntry:

../../../dist/include/xpcom/nsTHashtable.h: In static member function `static PRBool nsTHashtable<EntryType>::s_MatchEntry(PLDHashTable*, const PLDHashEntryHdr*, const void*) [with EntryType = nsCookieEntry]':
../../../dist/include/xpcom/nsTHashtable.h:334:   instantiated from `PRBool nsTHashtable<EntryType>::Init(PRUint32) [with EntryType = nsCookieEntry]'
nsCookieService.cpp:418:   instantiated from here
../../../dist/include/xpcom/nsTHashtable.h:367: warning: cast from `const PLDHashEntryHdr*' to `const nsCookieEntry*' increases required alignment of target type

I'm still not sure exactly what the 2 marked lines of code do:

(extract from nsTHashtable.h)

    361 template<class EntryType>
    362 PRBool
    363 nsTHashtable<EntryType>::s_MatchEntry(PLDHashTable          *table,
    364                                       const PLDHashEntryHdr *entry,
    365                                       const void            *key)
    366 {
--> 367   return ((const EntryType*) entry)->KeyEquals(
--> 368     static_cast<const KeyTypePointer>(key));
    369 }

but the error must be somewhere in these 2 lines, isn't it?

anton

-- 
Anton Shterenlikht
Room 2.6, Queen's Building
Mech Eng Dept
Bristol University
University Walk, Bristol BS8 1TR, UK
Tel: +44 (0)117 928 8233 
Fax: +44 (0)117 929 4423