[FEEDBACK REQUIRED] patch for ipfw/ipfw2 on alpha/sparc64

John Baldwin jhb at FreeBSD.org
Sat May 24 13:44:06 PDT 2003


On 24-May-2003 Peter Wemm wrote:
> Luigi Rizzo wrote:
> 
>>      if (cmd->opcode == O_LOG)
>>      cmd += F_LEN(cmd);
>> +#ifdef I386
>>      fs = ((ipfw_insn_pipe *)cmd)->pipe_ptr;
>> +#else
>> +    bcopy(& ((ipfw_insn_pipe *)cmd)->pipe_ptr, &fs, sizeof(fs));
>> +#endif
>>  
> 
> This is not a 'reviewed-by:', but these should be #ifdef __i386__
> rather than #ifdef I386.

Why is the #ifdef even there?  Why not use bcopy all the time?

-- 

John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/


More information about the freebsd-alpha mailing list