PERFORCE change 136345 for review (fwd)

[Alec Kloss]

On 2008-02-28 22:17,  wrote:
> On 2008-02-27 11:54, Robert Watson wrote:
> > 
> > Tomas,
> > 
> > Following a CVS update from the Arla anoncvs, I needed the attached patch 
> > to build on FreeBSD.  I still have the following further local changes in 
> > my tree still:
> > 
> > - Remove nnpfs_deb.h include from fs_local.h.
> > 
> > - Add /usr/include to various paths so that machine/whatever.h includes
> >   properly.
> > 
> > - #ifdef NNPFS_DEBUG around local variables in nnpfs_lk_info to avoid unused
> >   variables warning/error.
> 
> I've been playing with this some tonight.  My current thought about
> dealing with the "machine/whatever.h" includes is to copy the
> pertinent headers out of the kernel sources (via $SYS) at the same
> time configure generates vnode_if.h.  Any thoughts about that
> approach?  It's kinda unfortunate that these headers aren't inside
> a machine/ directory in /sys;  then we could -I these directly from 
> /sys.  Does anyone have any idea how this used to work?
> 
> I haven't loked at the NNPFS_DEBUG related issues yet, but I will.  

Hrm.  I didn't have any problems building arla on -CURRENT after
creating my machine/ hack.  I suppose a symlink would be more
appropriate than a copy for that.  Robert, did you need your other
changes to get Arla to compile, or were there just warnings you
were itching to fix?  It's time to shovel snow, but I'll be back at
this tomorrow evening.  If we can come to an agreement on the
machine includes and the nnpfs_debug stuff, tomorrow night I should
be able to implement whatever we decide on and update the ports
accordingly.  After that, I guess it's send-pr time for arla and
the ports maintainers.   :)

(Oh yeah, my change is just this:

oldothello% diff -u cf/*.orig cf/bsd-header-vnode-if-h.m4
--- cf/bsd-header-vnode-if-h.m4.orig    2008-02-28
23:01:01.000000000 -0600
+++ cf/bsd-header-vnode-if-h.m4 2008-02-28 22:42:32.000000000 -0600
@@ -25,6 +25,7 @@
   awk -f $SYS/tools/vnode_if.awk $SYS/kern/vnode_if.src -h
   awk -f $SYS/tools/vnode_if.awk $SYS/kern/vnode_if.src -p
   awk -f $SYS/tools/vnode_if.awk $SYS/kern/vnode_if.src -q
+  ln -sf $SYS/$(uname -m)/include machine
 else
   AC_MSG_ERROR(unable to find any vnode_if script)
 fi
oldothello%
)

-- 
Alec Kloss  alec at SetFilePointer.com   IM: angryspamhater at yahoo.com
PGP key at http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xA241980E
"No Bunny!" -- Simon, from Frisky Dingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-afs/attachments/20080229/f30f612c/attachment.pgp