Changes to OpenAFS to support FreeBSD 8-CURRENT

Matt Benjamin matt at linuxbox.com
Sat Dec 13 18:56:15 PST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi Ben,

I got your previous email, but wasn't sure I could get to this.  I
haven't in fact been focused on 8-CURRENT, but on vnode locking and
refcounting correctness across 7.0 to 8-CURRENT.  (Making headway...)

Anyway, I set that aside and whacked through a similar effort.  The
things you got sound right to me, though I'm surprised krx and
afs_server.c compiled, but, it might have to do with whether you have
network stack virtualization enabled.  The  module doesn't load
presumably because of unresolved externals--here either the
aforementioned (like in_ifaddrhead), and probably "suser(thread)" which
is gone, replaced with "priv_check(thread)" (what makes me think that
one won't be around long).

Openafs-1.4.8 (openafs.org) with RT # 123933 compiles and loads, as
above,  but I have not run the code, it's just to block something in, ATM.

Matt

Ben Kaduk wrote:
> Hi Boris,
> 
> To get a OpenAFS compiling on a couple-day-old current, I needed to
> change (in addition to
> the vinvalbuf change mentioned elsewhere)
> 
> VSUID to S_ISUID and VSGID to S_ISGID in VNOPS/afs_vnop_attrs.c
> from this change:
> trasz       2008-09-10 13:16:41 UTC
> (note that S_ISUID is from stat.h and VUID was from vnode.h)
> 
> remove the curthread argument from VOP_GETATTR() (two occurrences)
> in FBSD/osi_file.c:143  (this is under AFS_FBSD50_ENV ???)
> from this change:
> attilio     2008-08-28 15:23:18 UTC
> 
> The vinvalbuf change also affects FBSD/osi_vm.c in two lines.
> 
> change ap->a_mode to ap->a_accmode in FBSD/osi_vnodeops.c:691
> and in the comment above.  Arguably, this might be rather a bug
> in the vnode_if.h header where the structure is defined
> (libafs/MODLOAD/vnode_if.h, apparently).
> 
> Now, everything compiles, but kldload is claiming that libafs.ko
> doesn't exist ...
> 
> -Ben Kaduk
> _______________________________________________
> freebsd-afs at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-afs
> To unsubscribe, send any mail to "freebsd-afs-unsubscribe at freebsd.org"




- --

Matt Benjamin

The Linux Box
206 South Fifth Ave. Suite 150
Ann Arbor, MI  48104

http://linuxbox.com

tel. 734-761-4689
fax. 734-769-8938
cel. 734-216-5309

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJRHXBJiSUUSaRdSURCIEPAJsFcRHTBEDsWs4y2r3h0LJlQ7LjzgCdGJS4
uFYwecbqcgAQeA1bXhSnqG4=
=f20Q
-----END PGP SIGNATURE-----


More information about the freebsd-afs mailing list