suspend issues with latest -HEAD, ahci failing to complete something?

[Alexander Motin]

On 05.05.2014 20:37, Adrian Chadd wrote:
> (I know, I just emailed out asking about setting S3 for the default
> lid suspend state, however I just updated to the very latest head and
> things went a little backwards.)
>
> Suspend no longer works for me:
>
> May  5 10:33:10 lucy-11i386 acpi: suspend at 20140505 10:33:10
> May  5 10:33:47 lucy-11i386 kernel: ahcich0: Timeout on slot 19 port 0
> May  5 10:33:47 lucy-11i386 kernel: ahcich0: is 00000000 cs fff80fff
> ss fff80fff rs fff80fff tfd d0 serr 00000000 cmd 0000d317
> May  5 10:33:47 lucy-11i386 kernel: (ada0:ahcich0:0:0:0):
> WRITE_FPDMA_QUEUED. ACB: 61 08 e0 b0 fa 40 42 00 00 00 00 00
> May  5 10:33:47 lucy-11i386 kernel: (ada0:ahcich0:0:0:0): CAM status:
> Command timeout
> May  5 10:33:47 lucy-11i386 kernel: (ada0:ahcich0:0:0:0): Retrying command
> May  5 10:33:13 lucy-11i386 acpi: resumed at 20140505 10:33:13
>
> May  5 10:33:59 lucy-11i386 acpi: suspend at 20140505 10:33:59
> May  5 10:34:37 lucy-11i386 kernel: ahcich0: Timeout on slot 9 port 0
> May  5 10:34:37 lucy-11i386 kernel: ahcich0: is 00000000 cs ffffff83
> ss ffffff83 rs ffffff83 tfd d0 serr 00000000 cmd 0000c717
> May  5 10:34:37 lucy-11i386 kernel: (ada0:ahcich0:0:0:0):
> WRITE_FPDMA_QUEUED. ACB: 61 08 18 5c f7 40 42 00 00 00 00 00
> May  5 10:34:37 lucy-11i386 kernel: (ada0:ahcich0:0:0:0): CAM status:
> Command timeout
> May  5 10:34:37 lucy-11i386 kernel: (ada0:ahcich0:0:0:0): Retrying command
> May  5 10:34:03 lucy-11i386 acpi: resumed at 20140505 10:34:03
>
> What has recently changed that'd possibly break ahci's ability to
> correctly suspend?

When I tested it last time (awhile ago), it was working for me. 
ahci_ch_suspend() should block all I/O on the channel and wait until all 
active commands complete. On resume channel should be reinitialized, 
device reset and only then I/Os should be released. Do you see those 
timeouts on suspend or resume?

Do you have kern.cam.ada.spindown_suspend enabled? Can you try to 
disable it?

-- 
Alexander Motin