Dell acpi_video patch

Alberto Villa avilla at FreeBSD.org
Fri Oct 12 23:58:06 UTC 2012


On Fri, Oct 12, 2012 at 4:06 PM, John Baldwin <jhb at freebsd.org> wrote:
> I think this is correct, but in we need to do more to properly handle that
> flag (DOD_DEVID_SCHEME_STD).  Specifically, we shouldn't trust any bits in the
> device ID unless that bit is set (except for the special case of
> DOD_DEVID_LCD) as per my reading of the _DOD description in the ACPI 3.0b
> spec.  I think this larger patch will do that while also fixing your case:

I tested your patch and the only effect is that my three reported
screens (I'm on a laptop) changed from "crt" to "out" (I understand
why, from the code):

hw.acpi.video.out0.active: 1
hw.acpi.video.out1.active: 1
hw.acpi.video.out1.brightness: 100
hw.acpi.video.out1.fullpower: 100
hw.acpi.video.out1.economy: 50
hw.acpi.video.out1.levels: 100 50 0 10 20 30 40 50 60 70 80 90 100
hw.acpi.video.out2.active: 1

Is there something I can do to help you make them recognised
correctly, or is it fault of a buggy ACPI table?
-- 
Alberto Villa, FreeBSD committer <avilla at FreeBSD.org>
http://people.FreeBSD.org/~avilla


More information about the freebsd-acpi mailing list