Time to increase MAX_TASKS?

Sean Bruno seanbru at yahoo-inc.com
Mon Nov 12 17:24:33 UTC 2012


On Mon, 2012-08-13 at 11:54 -0700, Sean Bruno wrote:
> 
> On Wed, 2012-08-08 at 10:23 -0700, Moore, Robert wrote:
> > Just FYI, we've seen the AcpiOsExecute task Q get very large if
> > There is a GPE flood that results in many, many notify operations.
> > 
> > And in these cases, it was always related to the EC (Embedded Controller).
> > 
> > Bob
> > 
> > 
> For the time being, and because I don't know what I'm doing, I've bumped
> my local freebsd9 version to use (MAX_CPU *2).
> 
> I'm sure this means something horrific is about to happen to me that I
> just don't know about yet.
> 
> Sean
> 


This seems to "do the right thing" for now, any objections?

Index: acpivar.h
===================================================================
--- acpivar.h	(revision 242921)
+++ acpivar.h	(working copy)
@@ -476,7 +476,7 @@
 
 /* Default maximum number of tasks to enqueue. */
 #ifndef ACPI_MAX_TASKS
-#define	ACPI_MAX_TASKS		32
+#define	ACPI_MAX_TASKS		MAX(32, MAXCPU * 2)
 #endif
 
 /* Default number of task queue threads to start. */




More information about the freebsd-acpi mailing list