kern/150517: [acpi] acpi_ec does not work properly on Lenovo S10[e] (due to dynamic switching to polled mode)

[David Naylor]

The following reply was made to PR kern/150517; it has been noted by GNATS.

From: David Naylor <naylor.b.david at gmail.com>
To: Andriy Gapon <avg at icyb.net.ua>
Cc: bug-followup at freebsd.org
Subject: Re: kern/150517: [acpi] acpi_ec does not work properly on Lenovo S10[e] (due to dynamic switching to polled mode)
Date: Tue, 5 Oct 2010 21:01:35 +0200

 --nextPart3774253.k86G1yU3gG
 Content-Type: Text/Plain;
   charset="us-ascii"
 Content-Transfer-Encoding: quoted-printable
 
 On Tuesday 05 October 2010 20:28:18 Andriy Gapon wrote:
 > on 05/10/2010 20:54 David Naylor said the following:
 > > On Tuesday 05 October 2010 11:09:02 Andriy Gapon wrote:
 > >> Can you try the patch?
 > >> http://people.freebsd.org/~avg/acpi_ec.patch
 > >> Thanks a lot!
 > >=20
 > > Two notes about your patch:
 > >  - EcCheckStatus has changed position in the file resulting in a larger
 > >  than
 > >=20
 > > required change.
 >=20
 > Yes, it's now needed in a function that is defined earlier.
 > I could just have added a declaration for EcCheckStatus(), but for some
 > reason I decided to move its definition.
 >=20
 > >  - You no longer dynamically switch to polled mode.  Was that
 > >  intentional?
 >=20
 > Yes.  My opinion is that it should be up to user to forcefully switch to
 > polled mode.  Although perhaps this is an unwelcome change for some users.
 >  Need to weight pros and cons.
 >=20
 > > Your patchs works.  No errors were reported during the stress test,
 > > however running acpiconf takes a noticeably longer time to complete
 > > (before and with my patch it was instantaneous).  Setting
 > > debug.acpi.ec.timeout=3D25 improves responsiveness (reducing to 5
 > > resulting in GPE query failed messages).
 > >=20
 > > Accoring to time acpiconf takes upto 3 seconds to complete, after setti=
 ng
 > > debug.acpi.ec.timeout it takes upto 0.24 seconds.
 > >=20
 > > I changed EC_POLL_DELAY back to 5 and that didn't change anything.
 >=20
 > I will investigate this.
 > Thank you!
 
 Thanks, I've tried but have not been able to isolate the cause.  Polled mod=
 e=20
 works perfectly.  Something my patch was unable to do. =20
 
 --nextPart3774253.k86G1yU3gG
 Content-Type: application/pgp-signature; name=signature.asc 
 Content-Description: This is a digitally signed message part.
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.16 (FreeBSD)
 
 iEYEABECAAYFAkyrdhMACgkQUaaFgP9pFrLHiQCeM+1kVlq4poGSZ3rdEdornCuI
 PrMAn21LNhbMKbSgo+g3fBoVQa5YE9Ft
 =PBE8
 -----END PGP SIGNATURE-----
 
 --nextPart3774253.k86G1yU3gG--