initial value of tz_active
Nate Lawson
nate at root.org
Thu Apr 24 22:48:19 UTC 2008
Rui Paulo wrote:
>
> On 24 Apr 2008, at 22:17, Andriy Gapon wrote:
>
>> on 24/04/2008 01:37 Andriy Gapon said the following:
>>> I agree - this is a better approach.
>>> On a technical level - maybe use TZ_ACTIVE_UNKNOWN=-2 instead of a new
>>> variable.
>>> I'll try to work on this somewhere in the middle of May.
>>
>> I've couple of spare hours this evening, so I decided to not delay this
>> small thing until after the vacation.
>> Result is attached.
>> My short testing shows that the patch does the job and doesn't introduce
>> any problems.
>> @@ -543,6 +545,22 @@ acpi_tz_monitor(void *Context)
>> newflags |= TZ_THFLAG_CRT;
>>
>> /* If the active cooling state has changed, we have to switch
>> things. */
>> + if (sc->tz_active == TZ_ACTIVE_UNKNOWN) {
>> + /* We don't know which cooling device is on or off,
>
> Please make this:
> "/*"
> " * We don't ..."
> to comply with style.
> Looks good to me.
Me too, please commit with the style fix.
--
Nate
More information about the freebsd-acpi
mailing list