More ACPI patch problems..

[Nate Lawson]

Eric Anderson wrote:
> Nate Lawson wrote:
> 
>> Eric Anderson wrote:
>>
>>> After updating, I now see this when on battery:
>>> hw.acpi.battery.life: 97
>>> hw.acpi.battery.time: 337898
>>> hw.acpi.battery.state: 1
>>> hw.acpi.battery.units: 2
>>> hw.acpi.battery.info_expire: 5
>>>
>>> And when on AC, my battery life never gets to 100% (like it used to).
>>>
>>> All my systems info is here:
>>> http://www.googlebit.com/freebsd/
>>
>> Can you run with the attached debug printf patch and let me know the 
>> output?  Run it both on and off AC power.
> 
> On bootup, with AC plugged in:
> batt pass1: dev 0xc22f7500 ok valid state 0 cap 100 valid_rate 0
> batt pass1: dev 0xc22f7880 batt pass2: min 0 total_min 0 total_cap 100
> batt pass2: min 0 total_min 0 total_cap 99
> batt pass1: dev 0xc22f7500 ok valid state 0 cap 100 valid_rate 0
> batt pass1: dev 0xc22f7880 batt pass2: min 0 total_min 0 total_cap 100
> batt pass2: min 0 total_min 0 total_cap 99

This is fine.  It appears your second battery is not present.

> Now on battery:
> power_profile: changed to 'economy'
> batt pass1: dev 0xc22f7500 ok valid state 0 cap 100 valid_rate 0
> batt pass1: dev 0xc22f7880 batt pass2: min 0 total_min 0 total_cap 100
> batt pass2: min 0 total_min 0 total_cap 99
> batt pass1: dev 0xc22f7500 ok valid state 0 cap 100 valid_rate 0
> batt pass1: dev 0xc22f7880 batt pass2: min 0 total_min 0 total_cap 100
> batt pass2: min 0 total_min 0 total_cap 99
>
> And then something like:
> batt pass1: dev 0xc22f7500 ok valid state 1 cap 93 valid_rate 2483
> batt pass1: dev 0xc22f7880 batt pass2: min 104 total_min 104 total_cap 93
> batt pass2: min 329216 total_min 329320 total_cap 92
> batt pass1: dev 0xc22f7500 ok valid state 1 cap 93 valid_rate 2483
> batt pass1: dev 0xc22f7880 batt pass2: min 104 total_min 104 total_cap 93
> batt pass2: min 329216 total_min 329320 total_cap 92

It appears we're getting invalid capacity data from the not-present 2nd 
battery.  I just committed a patch that should fix this -- it zeroes the 
memory in question so we don't get random values for a battery that 
isn't present.

Please let me know if it fixes this for you.

-- 
Nate