[PATCH] NULL pointer checking in acpi_pcib.c

Nate Lawson nate at root.org
Mon Apr 19 20:48:02 PDT 2004


On Mon, 19 Apr 2004, Bruno Ducrot wrote:
> I have some little problem (probably a bug in the DSDT, I'm not sure) if
> there is not check for crsbuf.Pointer in acpi_pcib_route_interrupt()
> after calling acpi_AppendBufferResource().
> My latop hang if AC is off-line on boot, or even at runtime.
>
> I'm not sure if that correct, though, but acpi_pci_link_set_irq() will
> do this checking anyway, so I guess it's expected that the caller
> have to check the return value for crsbuff.Pointer after the call to
> acpi_AppendBufferResource(&crsbuf, ...).

Can you add some printfs before the NULL check I committed so that we can
figure out what resource is causing this trouble?  Printing the contents
of *res when crsbuf.Pointer == NULL would help.  Also a copy of your ASL
(from acpidump -t -d) would be good.

-Nate


More information about the freebsd-acpi mailing list