git: a8b89dff6ac0 - main - Disable acpi_timer_test by default

Colin Percival cperciva at FreeBSD.org
Wed Sep 8 01:32:34 UTC 2021


The branch main has been updated by cperciva:

URL: https://cgit.FreeBSD.org/src/commit/?id=a8b89dff6ac026e60983824889d3666842ff409b

commit a8b89dff6ac026e60983824889d3666842ff409b
Author:     Colin Percival <cperciva at FreeBSD.org>
AuthorDate: 2021-09-07 23:59:45 +0000
Commit:     Colin Percival <cperciva at FreeBSD.org>
CommitDate: 2021-09-08 01:31:55 +0000

    Disable acpi_timer_test by default
    
    This disables testing the ACPI timer by default, forcing the use of
    ACPI-fast rather than ACPI-safe.  The broken-ACPI-timers workaround
    can be re-enabled by setting the hw.acpi.timer_test_enabled=1 tunable.
    
    This speeds up the FreeBSD boot process by 140 ms on an EC2 c5.xlarge
    instance.
    
    This change will not be MFCed.
    
    Assuming no problems are reported, acpi_timer_test, the associated
    tunable, and the ACPI-safe timecounter should be removed in FreeBSD 15.
    
    Relnotes:       The ACPI-safe timer is disabled in favour of ACPI-fast;
                    if timekeeping issues are observed, please test with
                    hw.acpi.timer_test_enabled=1 in loader.conf and report
                    if that fixes the problem.
---
 sys/dev/acpica/acpi_timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/dev/acpica/acpi_timer.c b/sys/dev/acpica/acpi_timer.c
index 8be6e0edea7f..8e3947709b61 100644
--- a/sys/dev/acpica/acpi_timer.c
+++ b/sys/dev/acpica/acpi_timer.c
@@ -79,7 +79,7 @@ static int	acpi_timer_sysctl_freq(SYSCTL_HANDLER_ARGS);
 static void	acpi_timer_boot_test(void);
 
 static int	acpi_timer_test(void);
-static int	acpi_timer_test_enabled = 1;
+static int	acpi_timer_test_enabled = 0;
 TUNABLE_INT("hw.acpi.timer_test_enabled", &acpi_timer_test_enabled);
 
 static device_method_t acpi_timer_methods[] = {


More information about the dev-commits-src-main mailing list