git: 59b2caef0537 - main - libsa: Remove conflicting .global/.weak directive

Alex Richardson arichardson at FreeBSD.org
Tue Mar 30 14:19:57 UTC 2021


The branch main has been updated by arichardson:

URL: https://cgit.FreeBSD.org/src/commit/?id=59b2caef0537661397caf2ce1398cf802cb864b4

commit 59b2caef0537661397caf2ce1398cf802cb864b4
Author:     Alex Richardson <arichardson at FreeBSD.org>
AuthorDate: 2021-03-30 13:52:31 +0000
Commit:     Alex Richardson <arichardson at FreeBSD.org>
CommitDate: 2021-03-30 13:59:41 +0000

    libsa: Remove conflicting .global/.weak directive
    
    LLVM12 complains if you change the symbol binding:
    `error: _longjmp changed binding to STB_GLOBAL`
    In this case LLVM actually ignored the weak directive and used the
    later .global, but GNU as would mark the symbol as weak.
    None of the other architectures mark the libsa _setjmp as weak so
    just drop this directive.
---
 stand/libsa/amd64/_setjmp.S | 1 -
 1 file changed, 1 deletion(-)

diff --git a/stand/libsa/amd64/_setjmp.S b/stand/libsa/amd64/_setjmp.S
index 6d9a5fa13f8d..53ea6e9b5d52 100644
--- a/stand/libsa/amd64/_setjmp.S
+++ b/stand/libsa/amd64/_setjmp.S
@@ -63,7 +63,6 @@ ENTRY(_setjmp)
 	ret
 END(_setjmp)
 
-	.weak	CNAME(_longjmp)
 ENTRY(_longjmp)
 	movq	%rdi,%rdx
 	/* Restore the mxcsr, but leave exception flags intact. */


More information about the dev-commits-src-main mailing list