git: 87d65c747a43 - main - lib/msun: Allow building tests with WARNS=6

Kyle Evans kevans at freebsd.org
Mon Mar 22 14:37:30 UTC 2021


On Mon, Mar 22, 2021 at 7:01 AM Alex Richardson <arichardson at freebsd.org> wrote:
>
> The branch main has been updated by arichardson:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=87d65c747a4389901c2bbbcb1ec4878b2df7b32c
>
> commit 87d65c747a4389901c2bbbcb1ec4878b2df7b32c
> Author:     Alex Richardson <arichardson at FreeBSD.org>
> AuthorDate: 2021-02-25 14:28:17 +0000
> Commit:     Alex Richardson <arichardson at FreeBSD.org>
> CommitDate: 2021-03-22 11:55:07 +0000
>
>     lib/msun: Allow building tests with WARNS=6
>
>     The only change needed is to mark a few variables as static.
> ---
>  contrib/netbsd-tests/lib/libm/t_ldexp.c     | 19 +++++++++----------
>  contrib/netbsd-tests/lib/libm/t_precision.c |  4 ++--
>  contrib/netbsd-tests/lib/libm/t_round.c     |  2 +-
>  contrib/netbsd-tests/lib/libm/t_scalbn.c    |  2 +-
>  lib/msun/tests/Makefile                     |  2 +-
>  5 files changed, 14 insertions(+), 15 deletions(-)
>
> [... snip ...]
> diff --git a/lib/msun/tests/Makefile b/lib/msun/tests/Makefile
> index 309f49c6dddd..4ef25c0a909a 100644
> --- a/lib/msun/tests/Makefile
> +++ b/lib/msun/tests/Makefile
> @@ -88,7 +88,7 @@ SRCS.ilogb2_test=     ilogb_test.c
>
>  LIBADD+=       m
>
> -WARNS?=                1
> +WARNS?=                6
>
>  # Copied from lib/msun/Makefile
>  .if ${MACHINE_CPUARCH} == "i386"

Hi,

IMO, we should go ahead and drop this WARNS entirely now that it's the
default -- I changed it a while back so that all depths of userland
should get a natural WARNS=6 if it's undefined.

Thanks,

Kyle Evans


More information about the dev-commits-src-main mailing list