git: b358534ab1a9 - main - Remove XFAILs from fmaxmin test

Alex Richardson arichardson at FreeBSD.org
Mon Mar 22 12:00:26 UTC 2021


The branch main has been updated by arichardson:

URL: https://cgit.FreeBSD.org/src/commit/?id=b358534ab1a953fac5830012751232e2f0807cc0

commit b358534ab1a953fac5830012751232e2f0807cc0
Author:     Alex Richardson <arichardson at FreeBSD.org>
AuthorDate: 2021-03-22 11:40:17 +0000
Commit:     Alex Richardson <arichardson at FreeBSD.org>
CommitDate: 2021-03-22 11:55:06 +0000

    Remove XFAILs from fmaxmin test
    
    These appears to have been resolved by compiling the test with -fno-builtin
    and/or using a newer compiler.
    
    PR:             208703
    Reviewed By:    ngie
    Differential Revision: https://reviews.freebsd.org/D28884
---
 lib/msun/tests/fmaxmin_test.c | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/lib/msun/tests/fmaxmin_test.c b/lib/msun/tests/fmaxmin_test.c
index a89c10cc2554..06bd0a1ba7e0 100644
--- a/lib/msun/tests/fmaxmin_test.c
+++ b/lib/msun/tests/fmaxmin_test.c
@@ -94,13 +94,6 @@ testall(long double big, long double small)
 	}
 }
 
-/* Clang 3.8.0+ fails the invariants for testcase 6, 7, 10, and 11. */
-#if defined(__clang__) && \
-    ((__clang_major__ >  3)) || \
-    ((__clang_major__ == 3 && __clang_minor__ >= 8))
-#define	affected_by_bug_208703
-#endif
-
 ATF_TC_WITHOUT_HEAD(test1);
 ATF_TC_BODY(test1, tc)
 {
@@ -133,17 +126,11 @@ ATF_TC_BODY(test5, tc)
 ATF_TC_WITHOUT_HEAD(test6);
 ATF_TC_BODY(test6, tc)
 {
-#ifdef affected_by_bug_208703
-	atf_tc_expect_fail("fails invariant with clang 3.8+ (bug 208703)");
-#endif
 	testall(1.0, NAN);
 }
 ATF_TC_WITHOUT_HEAD(test7);
 ATF_TC_BODY(test7, tc)
 {
-#ifdef affected_by_bug_208703
-	atf_tc_expect_fail("fails invariant with clang 3.8+ (bug 208703)");
-#endif
 	testall(INFINITY, NAN);
 }
 
@@ -162,18 +149,12 @@ ATF_TC_BODY(test9, tc)
 ATF_TC_WITHOUT_HEAD(test10);
 ATF_TC_BODY(test10, tc)
 {
-#ifdef affected_by_bug_208703
-	atf_tc_expect_fail("fails invariant with clang 3.8+ (bug 208703)");
-#endif
 	testall(3.0, -INFINITY);
 }
 
 ATF_TC_WITHOUT_HEAD(test11);
 ATF_TC_BODY(test11, tc)
 {
-#ifdef affected_by_bug_208703
-	atf_tc_expect_fail("fails invariant with clang 3.8+ (bug 208703)");
-#endif
 	testall(NAN, NAN);
 }
 


More information about the dev-commits-src-main mailing list