git: d9a50109e238 - main - if_wg: release correct lock in noise_remote_begin_session()

Kyle Evans kevans at FreeBSD.org
Mon Mar 8 06:22:41 UTC 2021


The branch main has been updated by kevans:

URL: https://cgit.FreeBSD.org/src/commit/?id=d9a50109e238e2d0171f0e647821f82efb8d037d

commit d9a50109e238e2d0171f0e647821f82efb8d037d
Author:     Kyle Evans <kevans at FreeBSD.org>
AuthorDate: 2021-03-08 02:25:33 +0000
Commit:     Kyle Evans <kevans at FreeBSD.org>
CommitDate: 2021-03-08 06:21:03 +0000

    if_wg: release correct lock in noise_remote_begin_session()
    
    The keypair lock is not taken until later.
    
    Obtained from:  Jason A. Donenfeld via OpenBSD
    MFC after:      3 days
---
 sys/dev/if_wg/module/wg_noise.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/dev/if_wg/module/wg_noise.c b/sys/dev/if_wg/module/wg_noise.c
index 946a570916a6..0fa7664e66d5 100644
--- a/sys/dev/if_wg/module/wg_noise.c
+++ b/sys/dev/if_wg/module/wg_noise.c
@@ -454,7 +454,7 @@ noise_remote_begin_session(struct noise_remote *r)
 		    NOISE_SYMMETRIC_SIZE, NOISE_SYMMETRIC_SIZE, 0, 0,
 		    hs->hs_ck);
 	} else {
-		rw_exit_write(&r->r_keypair_lock);
+		rw_exit_write(&r->r_handshake_lock);
 		return EINVAL;
 	}
 


More information about the dev-commits-src-main mailing list