git: bb6e84c988d3 - main - poly1305: Don't export generic Poly1305_* symbols from xform_poly1305.c.

Stefan Esser se at freebsd.org
Fri Mar 5 20:27:38 UTC 2021


Am 05.03.21 um 21:05 schrieb Kyle Evans:
> On Fri, Mar 5, 2021 at 11:55 AM John Baldwin <jhb at freebsd.org> wrote:
>>
>> The branch main has been updated by jhb:
>>
>> URL: https://cgit.FreeBSD.org/src/commit/?id=bb6e84c988d3f54eff602ed544ceaa9b9fe3e9ff
>>
>> commit bb6e84c988d3f54eff602ed544ceaa9b9fe3e9ff
>> Author:     John Baldwin <jhb at FreeBSD.org>
>> AuthorDate: 2021-03-05 17:47:58 +0000
>> Commit:     John Baldwin <jhb at FreeBSD.org>
>> CommitDate: 2021-03-05 17:55:11 +0000
>>
>>      poly1305: Don't export generic Poly1305_* symbols from xform_poly1305.c.
>>
>>      There currently isn't a need to provide a public interface to a
>>      software Poly1305 implementation beyond what is already available via
>>      libsodium's APIs and these symbols conflict with symbols shared within
>>      the ossl.ko module between ossl_poly1305.c and ossl_chacha20.c.
>>
>>      Reported by:    se, kp
>>      Fixes:          78991a93eb9d
>>      Sponsored by:   Netflix
>> ---
>>   sys/opencrypto/xform_poly1305.c | 43 ++++++++++++-----------------------------
>>   sys/opencrypto/xform_poly1305.h | 16 ---------------
>>   2 files changed, 12 insertions(+), 47 deletions(-)
> 
> xform_poly1305.h also needs to stop being grouped in
> ^/include/Makefile (reported by jenkins via np)

AFAICT, sys/opencrypto/xform_poly1305.h needs to be restored ...

It is needed during buildworld (and present in stable/13).

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/dev-commits-src-main/attachments/20210305/f87b2359/attachment.sig>


More information about the dev-commits-src-main mailing list