git: 0f8dab45404f - main - linux(4): Fix timeout parameter of rt_sigtimedwait syscall, which is timespec not a timeval.

Dmitry Chagin dchagin at freebsd.org
Sun Jun 6 17:37:32 UTC 2021


On Sun, Jun 06, 2021 at 06:37:08PM +0200, Lutz Donnerhacke wrote:
> On Sun, Jun 06, 2021 at 02:40:21PM +0000, Dmitry Chagin wrote:
> > The branch main has been updated by dchagin:
> > 
> > URL: https://cgit.FreeBSD.org/src/commit/?id=0f8dab45404f347752470579feccc6d2739b9570
> > 
> > commit 0f8dab45404f347752470579feccc6d2739b9570
> > Author:     Dmitry Chagin <dchagin at FreeBSD.org>
> > AuthorDate: 2021-06-07 02:35:35 +0000
> > Commit:     Dmitry Chagin <dchagin at FreeBSD.org>
> > CommitDate: 2021-06-07 02:35:35 +0000
> > 
> >     linux(4): Fix timeout parameter of rt_sigtimedwait syscall, which is
> >     timespec not a timeval.
> >     
> >     MFC after:      2 weeks
> 
> May I ask, why NONE of those commits are discussed beforehand in Phabricator?
> freebsd/main is not intended to be used as a local development train by
> anybody who wants to play with a specific submodule.
> 
in the main, these are trivial changes, there too few reviewrs in the Linuxulator area
to spend their time. feel free to review, there are many requests.

> I don't want to see any of those "try and fix" commits to be MFCed into any
> stable without serious squashing and fixup runs, in order to minimize the
> impact on the stable trains. If there is a known bug in the commit, the
> MFCed commit must contain all the known necessary fixes to avoid any
> breakage of the stable train.
> 
> So please do not mess up the freebsd/main any further. Thank you.

please, re-read the committer's guide carefully, especially about
committers relations and pre-commit review.




More information about the dev-commits-src-main mailing list