git: 7045b1603bdf - main - socket: Implement SO_RERROR

[Shawn Webb]

On Wed, Jul 28, 2021 at 04:35:17PM +0000, Kevin Bowling wrote:
> The branch main has been updated by kbowling (ports committer):
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=7045b1603bdf054145dd958a4acc17b410fb62a0
> 
> commit 7045b1603bdf054145dd958a4acc17b410fb62a0
> Author:     Roy Marples <roy at marples.name>
> AuthorDate: 2021-07-28 15:46:59 +0000
> Commit:     Kevin Bowling <kbowling at FreeBSD.org>
> CommitDate: 2021-07-28 16:35:09 +0000
> 
>     socket: Implement SO_RERROR
>     
>     SO_RERROR indicates that receive buffer overflows should be handled as
>     errors. Historically receive buffer overflows have been ignored and
>     programs could not tell if they missed messages or messages had been
>     truncated because of overflows. Since programs historically do not
>     expect to get receive overflow errors, this behavior is not the
>     default.
>     
>     This is really really important for programs that use route(4) to keep
>     in sync with the system. If we loose a message then we need to reload
>     the full system state, otherwise the behaviour from that point is
>     undefined and can lead to chasing bogus bug reports.
>     
>     Reviewed by:    philip (network), kbowling (transport), gbe (manpages)
>     MFC after:      2 weeks
>     Differential Revision:  https://reviews.freebsd.org/D26652
> ---
>  lib/libc/sys/getsockopt.2                          | 10 +++++++-
>  sbin/route/route.c                                 | 13 +++++++++-
>  sys/kern/uipc_sockbuf.c                            | 24 +++++++++++++++++
>  sys/kern/uipc_socket.c                             | 30 ++++++++++++++++------
>  sys/kern/uipc_usrreq.c                             |  2 +-
>  sys/net/raw_usrreq.c                               | 11 ++++----
>  .../bluetooth/socket/ng_btsocket_hci_raw.c         |  1 +
>  sys/netgraph/ng_socket.c                           |  2 +-
>  sys/netinet/ip_divert.c                            |  2 +-
>  sys/netinet/ip_mroute.c                            |  2 +-
>  sys/netinet/raw_ip.c                               |  3 +--
>  sys/netinet/udp_usrreq.c                           |  2 +-
>  sys/netinet6/icmp6.c                               |  6 ++---
>  sys/netinet6/ip6_input.c                           |  1 +
>  sys/netinet6/ip6_mroute.c                          |  3 ++-
>  sys/netinet6/raw_ip6.c                             |  2 ++
>  sys/netinet6/send.c                                |  2 +-
>  sys/netinet6/udp6_usrreq.c                         |  2 +-
>  sys/netipsec/keysock.c                             | 10 ++++----
>  sys/sys/socket.h                                   |  1 +
>  sys/sys/socketvar.h                                |  6 ++++-
>  21 files changed, 100 insertions(+), 35 deletions(-)

Hey Kevin,

Would this commit be a good candidate for bumping __FreeBSD_version?

Thanks,

-- 
Shawn Webb
Cofounder / Security Engineer
HardenedBSD

https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/dev-commits-src-main/attachments/20210728/32a5578e/attachment.sig>