git: 7fa2f2a62f04 - main - Rename NO_WERROR -> MK_WERROR=no

[Antoine Brodin]

On Sun, Jan 10, 2021 at 12:12 PM Tijl Coosemans <tijl at coosemans.org> wrote:
>
> On Thu, 7 Jan 2021 11:05:55 GMT Alex Richardson
> <arichardson at FreeBSD.org> wrote:
> > The branch main has been updated by arichardson:
> >
> > URL: https://cgit.FreeBSD.org/src/commit/?id=7fa2f2a62f04f095e1e27ad55aa22a8f59b1df8f
> >
> > commit 7fa2f2a62f04f095e1e27ad55aa22a8f59b1df8f
> > Author:     Alex Richardson <Alexander.Richardson at cl.cam.ac.uk>
> > AuthorDate: 2021-01-06 17:55:06 +0000
> > Commit:     Alex Richardson <arichardson at FreeBSD.org>
> > CommitDate: 2021-01-07 09:31:03 +0000
> >
> >     Rename NO_WERROR -> MK_WERROR=no
> >
> >     As suggested in D27598. This also supports MK_WERROR.clang=no and
> >     MK_WERROR.gcc=no to support the existing NO_WERROR.<compiler> uses.
> >
> >     Reviewed By:    brooks
> >     Differential Revision: https://reviews.freebsd.org/D27601
> > ---
> > diff --git a/share/mk/bsd.opts.mk b/share/mk/bsd.opts.mk
> > index d0e7f1cb00ba..88c73cc6bfe4 100644
> > --- a/share/mk/bsd.opts.mk
> > +++ b/share/mk/bsd.opts.mk
> > @@ -65,7 +65,8 @@ __DEFAULT_YES_OPTIONS = \
> >      SSP \
> >      TESTS \
> >      TOOLCHAIN \
> > -    WARNS
> > +    WARNS \
> > +    WERROR
> >
> >  __DEFAULT_NO_OPTIONS = \
> >      BIND_NOW \
> > @@ -103,7 +104,8 @@ __DEFAULT_DEPENDENT_OPTIONS = \
> >      INSTALLLIB \
> >      MAN \
> >      PROFILE \
> > -    WARNS
> > +    WARNS \
> > +    WERROR
> >  .if defined(NO_${var})
> >  .error "NO_${var} is defined, but deprecated. Please use MK_${var}=no instead."
> >  MK_${var}:=no
>
> NO_WERROR is also used by some ports [1] (which have to build against
> multiple version of FreeBSD) and this turns it into an error.  Can you
> remove this change or turn it into a warning maybe?  Changes to share/mk
> should always go through a ports exp-run IMHO.

Ping Alex Richardson?

Antoine (with hat: portmgr)