git: b6999635b195 - main - iflib: Avoid double counting in rxeof

Mark Johnston markj at FreeBSD.org
Wed Feb 24 15:13:21 UTC 2021


The branch main has been updated by markj:

URL: https://cgit.FreeBSD.org/src/commit/?id=b6999635b195e8c0dd5c08ac9ff268c92107cc66

commit b6999635b195e8c0dd5c08ac9ff268c92107cc66
Author:     Mark Johnston <markj at FreeBSD.org>
AuthorDate: 2021-02-24 15:08:53 +0000
Commit:     Mark Johnston <markj at FreeBSD.org>
CommitDate: 2021-02-24 15:08:53 +0000

    iflib: Avoid double counting in rxeof
    
    iflib_rxeof() was counting everything twice.  This was introduced when
    pfil hooks were added to the iflib receive path.  We want to count rx
    packets/bytes before the pfil hooks are executed, so remove the counter
    adjustments that are executed after.
    
    PR:             253583
    Reviewed by:    gallatin, erj
    MFC after:      3 days
    Sponsored by:   The FreeBSD Foundation
    Differential Revision:  https://reviews.freebsd.org/D28900
---
 sys/net/iflib.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sys/net/iflib.c b/sys/net/iflib.c
index 6312499feac8..5366b652373d 100644
--- a/sys/net/iflib.c
+++ b/sys/net/iflib.c
@@ -2973,8 +2973,6 @@ iflib_rxeof(iflib_rxq_t rxq, qidx_t budget)
 		if (!IP_ALIGNED(m) && (m = iflib_fixup_rx(m)) == NULL)
 			continue;
 #endif
-		rx_bytes += m->m_pkthdr.len;
-		rx_pkts++;
 #if defined(INET6) || defined(INET)
 		if (lro_enabled) {
 			if (!lro_possible) {


More information about the dev-commits-src-main mailing list