git: 2ed689a674c3 - main - pf: Fix osfp configuration

Kristof Provost kp at FreeBSD.org
Thu Feb 18 08:39:05 UTC 2021


The branch main has been updated by kp:

URL: https://cgit.FreeBSD.org/src/commit/?id=2ed689a674c380e48245933d5326da4dda65f94d

commit 2ed689a674c380e48245933d5326da4dda65f94d
Author:     Kristof Provost <kp at FreeBSD.org>
AuthorDate: 2021-02-18 07:36:46 +0000
Commit:     Kristof Provost <kp at FreeBSD.org>
CommitDate: 2021-02-18 07:38:28 +0000

    pf: Fix osfp configuration
    
    pf_rule_to_krule() incorrectly converted the rule osfp configuration to
    the krule structure.
    
    Reported by:    delphij@
    MFC after:      3 days
---
 sys/netpfil/pf/pf_ioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/netpfil/pf/pf_ioctl.c b/sys/netpfil/pf/pf_ioctl.c
index ea71664756d7..c32a961f5a0b 100644
--- a/sys/netpfil/pf/pf_ioctl.c
+++ b/sys/netpfil/pf/pf_ioctl.c
@@ -1623,7 +1623,7 @@ pf_rule_to_krule(const struct pf_rule *rule, struct pf_krule *krule)
 	/* Don't allow userspace to set evaulations, packets or bytes. */
 	/* kif, anchor, overload_tbl are not copied over. */
 
-	krule->os_fingerprint = krule->os_fingerprint;
+	krule->os_fingerprint = rule->os_fingerprint;
 
 	krule->rtableid = rule->rtableid;
 	bcopy(rule->timeout, krule->timeout, sizeof(krule->timeout));


More information about the dev-commits-src-main mailing list