git: 682c31db4ecf - main - ipfw(8) crashes when ext6hdr option is omitted

[Kristof Provost]

The branch main has been updated by kp:

URL: https://cgit.FreeBSD.org/src/commit/?id=682c31db4ecfb8fc6cac0e8ad4945c03379ea3d1

commit 682c31db4ecfb8fc6cac0e8ad4945c03379ea3d1
Author:     Evgeniy Khramtsov <2khramtsov at gmail.com>
AuthorDate: 2021-02-01 19:03:57 +0000
Commit:     Kristof Provost <kp at FreeBSD.org>
CommitDate: 2021-02-01 20:25:11 +0000

    ipfw(8) crashes when ext6hdr option is omitted
    
    Verify that the option is passed, error out if it's not.
    The problem can be trivially triggered with `ipfw add allow ext6hdr`.
    
    PR:             253169
    Reviewed by:    kp@
    MFC after:      3 days
    Differential Revision:  https://reviews.freebsd.org/D28447
---
 sbin/ipfw/ipfw2.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sbin/ipfw/ipfw2.c b/sbin/ipfw/ipfw2.c
index 67303d8bb1e7..19f7f331091d 100644
--- a/sbin/ipfw/ipfw2.c
+++ b/sbin/ipfw/ipfw2.c
@@ -4961,6 +4961,7 @@ read_options:
 			break;
 
 		case TOK_EXT6HDR:
+			NEED1("missing extension header");
 			fill_ext6hdr( cmd, *av );
 			av++;
 			break;