git: a0694da5d035 - stable/12 - netgraph/ng_base: Renaming a node to the same name is a noop

[Lutz Donnerhacke]

The branch stable/12 has been updated by donner:

URL: https://cgit.FreeBSD.org/src/commit/?id=a0694da5d035ea0e686ad1bae95709e52df0913a

commit a0694da5d035ea0e686ad1bae95709e52df0913a
Author:     Lutz Donnerhacke <donner at FreeBSD.org>
AuthorDate: 2021-05-04 19:20:39 +0000
Commit:     Lutz Donnerhacke <donner at FreeBSD.org>
CommitDate: 2021-06-10 09:33:19 +0000

    netgraph/ng_base: Renaming a node to the same name is a noop
    
    Detailed analysis in https://github.com/genneko/freebsd-vimage-jails/issues/2
    brought the problem down to a double call of ng_node_name() before and
    after a vnet move.  Because the name of the node is already known
    (occupied by itself), the second call fails.
    
    PR:             241954
    Reported by:    Paul Armstrong
    Differential Revision: https://reviews.freebsd.org/D30110
    
    (cherry picked from commit 0345fd891fe13a191fc0fae9463ea9458bfaff5a)
---
 sys/netgraph/ng_base.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sys/netgraph/ng_base.c b/sys/netgraph/ng_base.c
index 4c6a2f606119..f7c2cdb9afb0 100644
--- a/sys/netgraph/ng_base.c
+++ b/sys/netgraph/ng_base.c
@@ -854,6 +854,10 @@ ng_name_node(node_p node, const char *name)
 	node_p node2;
 	int i;
 
+	/* Rename without change is a noop */
+	if (strcmp(NG_NODE_NAME(node), name) == 0)
+		return (0);
+
 	/* Check the name is valid */
 	for (i = 0; i < NG_NODESIZ; i++) {
 		if (name[i] == '\0' || name[i] == '.' || name[i] == ':')