git: bb048438e7e5 - stable/13 - igb: clean up igb_txrx comments

Kevin Bowling kbowling at FreeBSD.org
Tue Aug 3 02:05:48 UTC 2021


The branch stable/13 has been updated by kbowling (ports committer):

URL: https://cgit.FreeBSD.org/src/commit/?id=bb048438e7e580169b5255711ed8e6e9e9faf59c

commit bb048438e7e580169b5255711ed8e6e9e9faf59c
Author:     Kevin Bowling <kbowling at FreeBSD.org>
AuthorDate: 2021-07-31 15:04:25 +0000
Commit:     Kevin Bowling <kbowling at FreeBSD.org>
CommitDate: 2021-08-03 02:04:46 +0000

    igb: clean up igb_txrx comments
    
    Reviewed by:    grehan
    MFC after:      3 days
    Differential Revision:  https://reviews.freebsd.org/D31227
    
    (cherry picked from commit ff01d6343f1f0c6550e4072eddda91dabd366d09)
---
 sys/dev/e1000/igb_txrx.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/sys/dev/e1000/igb_txrx.c b/sys/dev/e1000/igb_txrx.c
index 75c5c160bf3e..2252270fa5ea 100644
--- a/sys/dev/e1000/igb_txrx.c
+++ b/sys/dev/e1000/igb_txrx.c
@@ -522,7 +522,6 @@ igb_rx_checksum(uint32_t staterr, if_rxd_info_t ri, uint32_t ptype)
 	uint16_t status = (uint16_t)staterr;
 	uint8_t errors = (uint8_t)(staterr >> 24);
 
-	/* Ignore Checksum bit is set */
 	if (__predict_false(status & E1000_RXD_STAT_IXSM))
 		return;
 
@@ -537,9 +536,7 @@ igb_rx_checksum(uint32_t staterr, if_rxd_info_t ri, uint32_t ptype)
 	/* Valid L4E checksum */
 	if (__predict_true(status &
 	    (E1000_RXD_STAT_TCPCS | E1000_RXD_STAT_UDPCS))) {
-		/* SCTP header present.
-		 * XXXKB: ETQF doesn't appear to be used in igb?
-		 */
+		/* SCTP header present */
 		if (__predict_false((ptype & E1000_RXDADV_PKTTYPE_ETQF) == 0 &&
 		    (ptype & E1000_RXDADV_PKTTYPE_SCTP) != 0)) {
 			ri->iri_csum_flags |= CSUM_SCTP_VALID;


More information about the dev-commits-src-branches mailing list