git: 3c9253c2f6d1 - stable/13 - pf: fix pagefault in pf_getstatus()

[Kristof Provost]

The branch stable/13 has been updated by kp:

URL: https://cgit.FreeBSD.org/src/commit/?id=3c9253c2f6d1f076ef35a5538b207a5cc866480f

commit 3c9253c2f6d1f076ef35a5538b207a5cc866480f
Author:     Kristof Provost <kp at FreeBSD.org>
AuthorDate: 2021-09-23 08:39:49 +0000
Commit:     Kristof Provost <kp at FreeBSD.org>
CommitDate: 2021-09-30 11:51:32 +0000

    pf: fix pagefault in pf_getstatus()
    
    We can't copyout() while holding a lock, in case it triggers a page
    fault.
    Release the lock before copyout, which is safe because we've already
    copied all the data into the nvlist.
    
    PR:             258601
    Reviewed by:    mjg
    MFC after:      1 week
    Sponsored by:   Modirum MDPay
    Differential Revision:  https://reviews.freebsd.org/D32076
    
    (cherry picked from commit cb13059663e455b3fc69c293dadec53c164490dc)
---
 sys/netpfil/pf/pf_ioctl.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sys/netpfil/pf/pf_ioctl.c b/sys/netpfil/pf/pf_ioctl.c
index aac47e5512cf..7a8d0cdda836 100644
--- a/sys/netpfil/pf/pf_ioctl.c
+++ b/sys/netpfil/pf/pf_ioctl.c
@@ -5017,11 +5017,14 @@ pf_getstatus(struct pfioc_nv *nv)
 	else if (nv->size < nv->len)
 		ERROUT(ENOSPC);
 
+	PF_RULES_RUNLOCK();
 	error = copyout(nvlpacked, nv->data, nv->len);
+	goto done;
 
 #undef ERROUT
 errout:
 	PF_RULES_RUNLOCK();
+done:
 	free(nvlpacked, M_NVLIST);
 	nvlist_destroy(nvc);
 	nvlist_destroy(nvl);