git: 6a460811b331 - main - ida: Use ida lock instead of Giant for bus_dma allocation

Warner Losh imp at FreeBSD.org
Thu Sep 30 01:18:57 UTC 2021


The branch main has been updated by imp:

URL: https://cgit.FreeBSD.org/src/commit/?id=6a460811b331d9f282811578d3d85f9a7e78936e

commit 6a460811b331d9f282811578d3d85f9a7e78936e
Author:     Warner Losh <imp at FreeBSD.org>
AuthorDate: 2021-09-30 01:05:39 +0000
Commit:     Warner Losh <imp at FreeBSD.org>
CommitDate: 2021-09-30 01:15:16 +0000

    ida: Use ida lock instead of Giant for bus_dma allocation
    
    It looks like a reference to Giant was overloooked when jhb made this
    MPSAFE in 6b5b57ae9f8f.
    
    Sponsored by:           Netflix
    Differential Revision:  https://reviews.freebsd.org/D31841
---
 sys/dev/ida/ida.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/dev/ida/ida.c b/sys/dev/ida/ida.c
index 10bba8146706..d45395a1febf 100644
--- a/sys/dev/ida/ida.c
+++ b/sys/dev/ida/ida.c
@@ -248,7 +248,7 @@ ida_setup(struct ida_softc *ida)
 		/* maxsegsz	*/ BUS_SPACE_MAXSIZE_32BIT,
 		/* flags	*/ 0,
 		/* lockfunc	*/ busdma_lock_mutex,
-		/* lockarg	*/ &Giant,
+		/* lockarg	*/ &ida->lock,
 		&ida->buffer_dmat);
 	if (error)
 		return (ENOMEM);


More information about the dev-commits-src-all mailing list