git: effc8e57fbf0 - main - libalias: Style cleanup

Lutz Donnerhacke lutz at donnerhacke.de
Sat May 15 20:51:42 UTC 2021


On Sat, May 15, 2021 at 11:14:31PM +0300, Konstantin Belousov wrote:
> On Sat, May 15, 2021 at 09:58:12PM +0200, Lutz Donnerhacke wrote:
> > Of course it was a style commit.
> > 
> > + /*
> > +      De-alias incoming echo and timestamp replies.
> > +      Alias incoming echo and timestamp requests.
> > +  */
> >   static int
> >   IcmpAliasIn1(struct libalias *la, struct ip *pip)
> >   {
> > -
> > 	LIBALIAS_LOCK_ASSERT(la);
> > - /*
> > -      De-alias incoming echo and timestamp replies.
> > -      Alias incoming echo and timestamp requests.
> > -  */
> >  	struct alias_link *lnk;
>
> I do not understand what are you trying to say.

The diff above is a reformatting of the original diff in the commit.
It does show, what really happend during the edit:
  - The empty line at the beginnen of the function body was removed
  - The comment at the beginning of the function body was moved
    before the function definition.

The LIBALIAS_LOCK_ASSERT and the variable declarations were not moved.


More information about the dev-commits-src-all mailing list