git: aacfedcef1b2 - stable/12 - pf tests: Test automatically generated tables

Kristof Provost kp at FreeBSD.org
Mon May 10 19:49:51 UTC 2021


The branch stable/12 has been updated by kp:

URL: https://cgit.FreeBSD.org/src/commit/?id=aacfedcef1b279f97286885fa62baa21ff1da09a

commit aacfedcef1b279f97286885fa62baa21ff1da09a
Author:     Kristof Provost <kp at FreeBSD.org>
AuthorDate: 2021-04-26 09:14:44 +0000
Commit:     Kristof Provost <kp at FreeBSD.org>
CommitDate: 2021-05-10 19:46:06 +0000

    pf tests: Test automatically generated tables
    
    Add a test case where the pfctl optimizer will generate a table
    automatically. These tables have long names, which we accidentally broke
    in the nvlist ADDRULE ioctl.
    
    Reviewed by:    melifaro
    MFC after:      2 weeks
    Sponsored by:   Rubicon Communications, LLC ("Netgate")
    Differential Revision:  https://reviews.freebsd.org/D29989
    
    (cherry picked from commit 08d77308211f823b8532d27790e8fd29eaf75c77)
---
 tests/sys/netpfil/pf/table.sh | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/tests/sys/netpfil/pf/table.sh b/tests/sys/netpfil/pf/table.sh
index 5826fab245d8..ff2a68b81224 100644
--- a/tests/sys/netpfil/pf/table.sh
+++ b/tests/sys/netpfil/pf/table.sh
@@ -177,10 +177,48 @@ network_cleanup()
 	pft_cleanup
 }
 
+atf_test_case "automatic" "cleanup"
+automatic_head()
+{
+	atf_set descr "Test automatic - optimizer generated - tables"
+	atf_set require.user root
+}
+
+automatic_body()
+{
+	pft_init
+
+	epair=$(vnet_mkepair)
+	ifconfig ${epair}a 192.0.2.1/24 up
+
+	vnet_mkjail alcatraz ${epair}b
+	jexec alcatraz ifconfig ${epair}b 192.0.2.2/24 up
+	jexec alcatraz pfctl -e
+
+	pft_set_rules alcatraz \
+		"block in" \
+		"pass in proto icmp from 192.0.2.1" \
+		"pass in proto icmp from 192.0.2.3" \
+		"pass in proto icmp from 192.0.2.4" \
+		"pass in proto icmp from 192.0.2.5" \
+		"pass in proto icmp from 192.0.2.6" \
+		"pass in proto icmp from 192.0.2.7" \
+		"pass in proto icmp from 192.0.2.8" \
+		"pass in proto icmp from 192.0.2.9"
+
+	atf_check -s exit:0 -o ignore ping -c 1 192.0.2.2
+}
+
+automatic_cleanup()
+{
+	pft_cleanup
+}
+
 atf_init_test_cases()
 {
 	atf_add_test_case "v4_counters"
 	atf_add_test_case "v6_counters"
 	atf_add_test_case "pr251414"
 	atf_add_test_case "network"
+	atf_add_test_case "automatic"
 }


More information about the dev-commits-src-all mailing list