git: 5d8fd932e418 - main - This brings into sync FreeBSD with the netflix versions of rack and bbr. This fixes several breakages (panics) since the tcp_lro code was committed that have been reported. Quite a few new features are now in rack (prefecting of DGP -- Dynamic Goodput Pacing among the largest). There is also support for ack-war prevention. Documents comming soon on rack..

[Li-Wen Hsu]

On Thu, May 6, 2021 at 11:26 PM Randall Stewart <rrs at freebsd.org> wrote:
>
> The branch main has been updated by rrs:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=5d8fd932e418f03e98b3469c4088a36f0ef34ffe
>
> commit 5d8fd932e418f03e98b3469c4088a36f0ef34ffe
> Author:     Randall Stewart <rrs at FreeBSD.org>
> AuthorDate: 2021-05-06 15:22:26 +0000
> Commit:     Randall Stewart <rrs at FreeBSD.org>
> CommitDate: 2021-05-06 15:22:26 +0000
>
>     This brings into sync FreeBSD with the netflix versions of rack and bbr.
>     This fixes several breakages (panics) since the tcp_lro code was
>     committed that have been reported. Quite a few new features are
>     now in rack (prefecting of DGP -- Dynamic Goodput Pacing among the
>     largest). There is also support for ack-war prevention. Documents
>     comming soon on rack..
>
>     Sponsored by:           Netflix
>     Reviewed by:            rscheff, mtuexen
>     Differential Revision:  https://reviews.freebsd.org/D30036

This seems braking LINT kernel build of powerpc:

https://ci.freebsd.org/job/FreeBSD-main-powerpc-LINT/6082/console

Searching "error:" leads to:

00:08:15.153 /workspace/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:2143:16:
error: implicit declaration of function 'tcp_hw_highest_rate' is
invalid in C99 [-Werror,-Wimplicit-function-declaration]
00:08:15.153                         high_rate =
tcp_hw_highest_rate(rack->r_ctl.crte);
00:08:15.153                                     ^

and

00:08:15.163 /workspace/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:2165:16:
error: implicit declaration of function 'tcp_hw_highest_rate_ifp' is
invalid in C99 [-Werror,-Wimplicit-function-declaration]
00:08:15.163                         high_rate =
tcp_hw_highest_rate_ifp(rack->rc_inp->inp_route.ro_nh->nh_ifp,
rack->rc_inp);
00:08:15.163                                     ^

I suspect this is because RATELIMIT is not defined in default powerpc
build? Is it safe to enable it?

Best,
Li-Wen