git: 74ae3f3e33b8 - main - if_wg: import latest fixup work from the wireguard-freebsd project

[Alexey Dokuchaev]

On Mon, Mar 15, 2021 at 08:56:56AM -0600, Scott Long wrote:
> Here is the response I sent to you and Donenfeld in private.  I won't
> include my direct conversation with you from Slack/IRC, but I made my
> concerns and objections pretty clear.  This commit is quite
> disappointing.

FWIW, original wireguard commit seemed more disappointing to me.

> - The LKML wouldn't accept this kind of submission, they'd insist
> that it be broken down into consumable pieces, and that bug fixes be
> considered and provided that don't rely on massive re-writes.

Didn't Linux folks also refuse to accept wireguard code until it was
ported from some home-grown "hey, let's do crypto stuff ourselves!"
implementation to their standard kernel APIs?

> - An accusation was made, tonight, to me, that the code Netgate
> sponsored was not reviewed and was shoved into the tree at the last
> minute.  This grossly ignores the actual history to the point of
> weakening my tolerance for this entire discussion.  It shows a
> pretty irrational bias against mmacy [...]

Slightly tangential note, but my questions to mmacy@ about original
wireguard commit (and ZoL, FWIW) or Phabricator comments had not been
answered; I also recall reviews being closed in "not accepted" state
by him.  While I appreciate the heavy-lifting, developers should be
ready to explain and sometimes defend their work on public forums.

> - The removal of the ASM crypto bits really confuses me.

But addition of the new crypto code, bypassing our crypto framework
in the first place did not?

Anyway, I'm really happy to see Jason's work; looks like sanity is
something FreeBSD can, once again, be known for. ;-)

./danfe