git: 0b3948e73b74 - main - softdep_unmount: assert that no dandling dependencies are left

Konstantin Belousov kib at FreeBSD.org
Fri Mar 12 11:32:33 UTC 2021


The branch main has been updated by kib:

URL: https://cgit.FreeBSD.org/src/commit/?id=0b3948e73b749b0fefc3f9d4fc61f356542bb9b9

commit 0b3948e73b749b0fefc3f9d4fc61f356542bb9b9
Author:     Konstantin Belousov <kib at FreeBSD.org>
AuthorDate: 2021-03-06 09:52:10 +0000
Commit:     Konstantin Belousov <kib at FreeBSD.org>
CommitDate: 2021-03-12 11:31:08 +0000

    softdep_unmount: assert that no dandling dependencies are left
    
    Reviewed by:    mckusick
    Tested by:      pho
    Sponsored by:   The FreeBSD Foundation
    MFC after:      2 weeks
    Differential revision:  https://reviews.freebsd.org/D29178
---
 sys/ufs/ffs/ffs_softdep.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sys/ufs/ffs/ffs_softdep.c b/sys/ufs/ffs/ffs_softdep.c
index cd00181b3c21..0091b5dcd3b8 100644
--- a/sys/ufs/ffs/ffs_softdep.c
+++ b/sys/ufs/ffs/ffs_softdep.c
@@ -2825,6 +2825,13 @@ softdep_unmount(mp)
 	FREE_GBLLOCK(&lk);
 	ump->um_softdep = NULL;
 
+	KASSERT(ums->sd_on_journal == 0,
+	    ("ump %p ums %p on_journal %d", ump, ums, ums->sd_on_journal));
+	KASSERT(ums->sd_on_worklist == 0,
+	    ("ump %p ums %p on_worklist %d", ump, ums, ums->sd_on_worklist));
+	KASSERT(ums->sd_deps == 0,
+	    ("ump %p ums %p deps %d", ump, ums, ums->sd_deps));
+
 	/*
 	 * Free up our resources.
 	 */


More information about the dev-commits-src-all mailing list