git: bb6e84c988d3 - main - poly1305: Don't export generic Poly1305_* symbols from xform_poly1305.c.

Fri Mar 5 20:40:53 UTC 2021

In message <3e76fccd-efeb-1479-7418-7e69bed98915 at freebsd.org>, Stefan Esser 
wri
tes:
> This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
> --BzEcQZ2nusRpdURvGKXTcE63zI1f9CPzu
> Content-Type: multipart/mixed; boundary="j85mRpT9Yj12HfXzWxaH0rMreDxXIgaOS";
>  protected-headers="v1"
> From: Stefan Esser <se at freebsd.org>
> To: Kyle Evans <kevans at freebsd.org>, John Baldwin <jhb at freebsd.org>
> Cc: src-committers <src-committers at freebsd.org>,
>  dev-commits-src-all at freebsd.org, dev-commits-src-main at freebsd.org
> Message-ID: <3e76fccd-efeb-1479-7418-7e69bed98915 at freebsd.org>
> Subject: Re: git: bb6e84c988d3 - main - poly1305: Don't export generic
>  Poly1305_* symbols from xform_poly1305.c.
> References: <202103051755.125HtZsc073704 at gitrepo.freebsd.org>
>  <CACNAnaE9xBWJdxuUnUmz8=Qe7GaekJL0Gm=Hwcnoma3F=97d9w at mail.gmail.com>
> In-Reply-To: <CACNAnaE9xBWJdxuUnUmz8=Qe7GaekJL0Gm=Hwcnoma3F=97d9w at mail.gmail.
> com>
> 
> --j85mRpT9Yj12HfXzWxaH0rMreDxXIgaOS
> Content-Type: text/plain; charset=utf-8; format=flowed
> Content-Language: de-DE
> Content-Transfer-Encoding: quoted-printable
>
> Am 05.03.21 um 21:05 schrieb Kyle Evans:
> > On Fri, Mar 5, 2021 at 11:55 AM John Baldwin <jhb at freebsd.org> wrote:
> >>
> >> The branch main has been updated by jhb:
> >>
> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3Dbb6e84c988d3f54eff602ed=
> 544ceaa9b9fe3e9ff
> >>
> >> commit bb6e84c988d3f54eff602ed544ceaa9b9fe3e9ff
> >> Author:     John Baldwin <jhb at FreeBSD.org>
> >> AuthorDate: 2021-03-05 17:47:58 +0000
> >> Commit:     John Baldwin <jhb at FreeBSD.org>
> >> CommitDate: 2021-03-05 17:55:11 +0000
> >>
> >>      poly1305: Don't export generic Poly1305_* symbols from xform_poly=
> 1305.c.
> >>
> >>      There currently isn't a need to provide a public interface to a
> >>      software Poly1305 implementation beyond what is already available=
>  via
> >>      libsodium's APIs and these symbols conflict with symbols shared w=
> ithin
> >>      the ossl.ko module between ossl_poly1305.c and ossl_chacha20.c.
> >>
> >>      Reported by:    se, kp
> >>      Fixes:          78991a93eb9d
> >>      Sponsored by:   Netflix
> >> ---
> >>   sys/opencrypto/xform_poly1305.c | 43 ++++++++++++-------------------=
> ----------
> >>   sys/opencrypto/xform_poly1305.h | 16 ---------------
> >>   2 files changed, 12 insertions(+), 47 deletions(-)
> >=20
> > xform_poly1305.h also needs to stop being grouped in
> > ^/include/Makefile (reported by jenkins via np)
>
> AFAICT, sys/opencrypto/xform_poly1305.h needs to be restored ...
>
> It is needed during buildworld (and present in stable/13).

Indeed.

`xform_poly1305.h' was not built (being made, type OP_DEPS_FOUND|OP_MARK, 
flags REMAKE|DONE_WAIT|DONE_ALLSRC|DONECYCLE)!
`_INCSINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_FO
UND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)!
`_ACPICAINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_
FOUND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)!
`_AGPINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_FOU
ND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)!
`_CRYPTOINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_
FOUND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)!
`_EVDEVINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_F
OUND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)!
`_FS9660INS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_
FOUND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)!
`_HIDINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_FOU
ND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)!
`_HYPERVINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_
FOUND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)!
`_PCIINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_FOU
ND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)!
`_RPCINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_FOU
ND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)!
`_TEKENINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_F
OUND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)!
`_VERIEXECINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEP
S_FOUND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)!
`_IPFILTERINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEP
S_FOUND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)!
`_PFINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_FOUN
D|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)!
`_NVPAIRINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_
FOUND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)!
`_MLX5INS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_FO
UND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)!
`compat' was not built (unmade, type OP_DEPENDS|OP_PHONY|OP_HAS_COMMANDS|OP_
DEPS_FOUND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)!

make[2]: stopped in /opt/src/git-src
--- includes_subdir_lib ---

make[2]: stopped in /opt/src/git-src
--- includes_subdir_bin ---

make[2]: stopped in /opt/src/git-src
--- includes_subdir_cddl ---

make[2]: stopped in /opt/src/git-src
--- includes_subdir_kerberos5 ---

make[2]: stopped in /opt/src/git-src
--- includes_subdir_libexec ---

make[2]: stopped in /opt/src/git-src

make[1]: stopped in /opt/src/git-src

make: stopped in /opt/src/git-src

-- 
Cheers,
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  https://FreeBSD.org
NTP:           <cy at nwtime.org>    Web:  https://nwtime.org

	The need of the many outweighs the greed of the few.