git: 2c26d77d989a - main - Remove /boot/efi from mtree, missed in 0b7472b3d8d2.

Rodney W. Grimes freebsd at gndrsh.dnsmgr.net
Wed Mar 3 12:54:01 UTC 2021


> OK, how about this as an idea then:
> 
> Parse mount output to see if anything is mounted to /boot/efi directly?
> 
> if mount -p | cut -f 2 | grep '^/boot/efi$'; then
> ....
> fi

What am I missing here?  One place I am being told this is run in
an environment that may not even be an EFI booted system, and in
another place it is being used as a test if something is mounted
on it, which should only be true on an EFI booted system.

Using the existance of a directory or something mounted on that
directory is probably one of the worse ways to make a decsiion
about if the system is or is not EFI capable, or if it needs
or doesnt need EFI support stuff.

I often boot from a MBR sd card or usb memstick and install an
EFI system on another type of media.  I am sure there is stuff
in the release process that has to make EFI related platform
issues, and that should probably be controled by a platform
specific MK_foo knob, and not by these "exists" tests.

>   Brandon Bergren
>   bdragon at FreeBSD.org
-- 
Rod Grimes                                                 rgrimes at freebsd.org


More information about the dev-commits-src-all mailing list