git: 0b7472b3d8d2 - main - Mount the EFI system partition (ESP) on newly-installed systems.

[Nathan Whitehorn]

On 3/1/21 1:39 PM, Brandon Bergren wrote:
> On Mon, Mar 1, 2021, at 12:28 PM, Brandon Bergren wrote:
>>
>> On Mon, Mar 1, 2021, at 11:54 AM, Nathan Whitehorn wrote:
>>> The /boot/uboot in BSD.root.dist also looks like cruft to me, but maybe
>>> best to leave for now?
>>> -Nathan
>> It's used on Book-E powerpc* in some cases (and the bootloader is
>> compiled and installed there by default on powerpc*) but it's a regular
>> directory. I don't believe there's any custom behavior to treat it as a
>> mount point because setting up booting is a machine specific thing in
>> this case, and the user is expected to do something like copy it to the
>> boot server or a partition on the bootstrap media.
>>
>> For example, on the X5000, the boot firmware is stored on an onboard SD
>> card that has space left to install loaders and stuff, but this is
>> something that is set up by hand.
>>
> Another thing to be aware of:
>
> On PowerNV (and Playstation 3, although that has bitrotted a bit), we currently use a ms-basic-data or fat32 partition mounted as /boot so that petitboot can load the kernel for direct execution. We do this because fat32 is the only filesystem we have in common with petitboot that we can easily write to.
>
> Be aware of this when changing detection behavior that we do in fact need this mounted as /boot and not as a subdirectory because of the way we currently do direct-execution on PowerNV. At the moment the behavior is isolated in partedit/partedit.powerpc but if the generic scripts are changed in a way where some assumption that /boot itself lives on the root filesystem comes into play, that they will have to special-case this.
>

This is one reason I really don't want any of this mechanism to be 
generic. I'd like the knowledge about the layout to be limited to the 
partition editor, which can signal to later parts of the install/upgrade 
process as needed. As written here for EFI, it is meant to do this by 
the presence of the EFI partition.
-Nathan