git: 175841285e28 - main - Add deprecation notice for WITH_PROFILE option

[Kyle Evans]

On Mon, Jun 28, 2021 at 8:37 AM Ed Maste <emaste at freebsd.org> wrote:
>
> The branch main has been updated by emaste:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=175841285e289edebb6603da39f02549521ce950
>
> commit 175841285e289edebb6603da39f02549521ce950
> Author:     Ed Maste <emaste at FreeBSD.org>
> AuthorDate: 2021-06-27 17:21:26 +0000
> Commit:     Ed Maste <emaste at FreeBSD.org>
> CommitDate: 2021-06-28 15:36:59 +0000
>
>     Add deprecation notice for WITH_PROFILE option
>
>     As discussed on freebsd-current [1] and freebsd-arch [2] and review
>     D30833, FreeBSD 14 will ship without the _p.a libraries built with -pg.
>     Both upstream and base system (in commit b762974cf4b9) Clang have been
>     modified to remove the special case for linking against these libraries.
>
>     Clang's -pg support and mcount() remain, so building with -pg can still
>     be used on code that the user builds; we just do not provide prebuilt
>     libraries compiled with -pg.  A similar change is still needed for GCC.
>
>     [1]  https://lists.freebsd.org/pipermail/freebsd-current/2020-January/075105.html
>     [2] https://lists.freebsd.org/archives/freebsd-arch/2021-June/000016.html
>
>     MFC after:      1 week
>     Sponsored by:   The FreeBSD Foundation
> ---
>  tools/build/options/WITHOUT_PROFILE | 2 ++
>  tools/build/options/WITH_PROFILE    | 2 ++
>  2 files changed, 4 insertions(+)
>
> diff --git a/tools/build/options/WITHOUT_PROFILE b/tools/build/options/WITHOUT_PROFILE
> index 7fdb12c94cdd..5cc8dbb027c8 100644
> --- a/tools/build/options/WITHOUT_PROFILE
> +++ b/tools/build/options/WITHOUT_PROFILE
> @@ -1,3 +1,5 @@
>  .\" $FreeBSD$
>  Do not build profiled libraries for use with
>  .Xr gprof 8 .
> +This option is enabled by default as of
> +.Fx 14 .

I know we could bikeshed this all day, but I think this verbiage is a
little too casual; "enabled by default" makes it sound like it can be
turned off, when it's really becoming non-optional.

> diff --git a/tools/build/options/WITH_PROFILE b/tools/build/options/WITH_PROFILE
> index 51814a1ea856..3f91c4394911 100644
> --- a/tools/build/options/WITH_PROFILE
> +++ b/tools/build/options/WITH_PROFILE
> @@ -1,3 +1,5 @@
>  .\" $FreeBSD$
>  Build profiled libraries for use with
>  .Xr gprof 8 .
> +This option is deprecated and is not present in
> +.Fx 14