git: 3fd20a79e7b5 - main - libalias: Stats are unsigned

Lutz Donnerhacke donner at FreeBSD.org
Sat Jun 19 16:22:25 UTC 2021


The branch main has been updated by donner:

URL: https://cgit.FreeBSD.org/src/commit/?id=3fd20a79e7b55d135bbc5fa197980fe0e9ee0f14

commit 3fd20a79e7b55d135bbc5fa197980fe0e9ee0f14
Author:     Lutz Donnerhacke <donner at FreeBSD.org>
AuthorDate: 2021-05-31 22:08:24 +0000
Commit:     Lutz Donnerhacke <donner at FreeBSD.org>
CommitDate: 2021-06-19 16:21:17 +0000

    libalias: Stats are unsigned
    
    Stats counters are used as unsigned valued (i.e. printf("%u")) but are
    defined as signed int.  This causes trouble later, so fix it early.
    
    MFC after:      1 week
    Differential Revision: https://reviews.freebsd.org/D30587
---
 sys/netinet/libalias/alias_local.h | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/sys/netinet/libalias/alias_local.h b/sys/netinet/libalias/alias_local.h
index fcdaa1690470..8e2fe88fe620 100644
--- a/sys/netinet/libalias/alias_local.h
+++ b/sys/netinet/libalias/alias_local.h
@@ -97,14 +97,14 @@ struct libalias {
 	/* HouseKeeping */
 	TAILQ_HEAD    (, alias_link) checkExpire;
 	/* Link statistics */
-	int		icmpLinkCount;
-	int		udpLinkCount;
-	int		tcpLinkCount;
-	int		pptpLinkCount;
-	int		protoLinkCount;
-	int		fragmentIdLinkCount;
-	int		fragmentPtrLinkCount;
-	int		sockCount;
+	unsigned int	icmpLinkCount;
+	unsigned int	udpLinkCount;
+	unsigned int	tcpLinkCount;
+	unsigned int	pptpLinkCount;
+	unsigned int	protoLinkCount;
+	unsigned int	fragmentIdLinkCount;
+	unsigned int	fragmentPtrLinkCount;
+	unsigned int	sockCount;
 	/* System time in seconds for current packet */
 	int		timeStamp;
 	/* If equal to zero, DeleteLink()


More information about the dev-commits-src-all mailing list